nastra commented on code in PR #3654:
URL: https://github.com/apache/parquet-java/pull/3654#discussion_r3549363274
##########
parquet-common/src/test/java/org/apache/parquet/SemanticVersionTest.java:
##########
@@ -18,34 +18,29 @@
*/
package org.apache.parquet;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
import java.util.List;
import org.junit.Test;
public class SemanticVersionTest {
@Test
public void testCompare() {
- assertTrue(new SemanticVersion(1, 8, 1).compareTo(new SemanticVersion(1,
8, 1)) == 0);
- assertTrue(new SemanticVersion(1, 8, 0).compareTo(new SemanticVersion(1,
8, 1)) < 0);
- assertTrue(new SemanticVersion(1, 8, 2).compareTo(new SemanticVersion(1,
8, 1)) > 0);
+ assertThat(new SemanticVersion(1, 8, 1)).isEqualByComparingTo(new
SemanticVersion(1, 8, 1));
+ assertThat(new SemanticVersion(1, 8, 0)).isLessThan(new SemanticVersion(1,
8, 1));
+ assertThat(new SemanticVersion(1, 8, 2)).isGreaterThan(new
SemanticVersion(1, 8, 1));
- assertTrue(new SemanticVersion(1, 8, 1).compareTo(new SemanticVersion(1,
8, 1)) == 0);
Review Comment:
these 3 checks were checking the same thing and were duplicates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
