nastra commented on code in PR #3654:
URL: https://github.com/apache/parquet-java/pull/3654#discussion_r3549539230
##########
parquet-common/src/test/java/org/apache/parquet/bytes/TestDeprecatedBufferInputStream.java:
##########
@@ -96,57 +96,57 @@ public void testSliceData() throws Exception {
buffers.add(stream.slice(bytesToSlice));
}
- Assert.assertEquals("Position should be at end", length,
stream.position());
- Assert.assertEquals("Should produce 5 buffers", 5, buffers.size());
+ assertThat(stream.position()).as("Position should be at
end").isEqualTo(length);
+ assertThat(buffers).as("Should produce 5 buffers").hasSize(5);
int i = 0;
ByteBuffer one = buffers.get(0);
- Assert.assertSame("Should use the same backing array", one.array(),
data.array());
Review Comment:
this is an example where the actual/expected parameters are flipped in the
JUnit4 Assert. We're expecting `one` to be the actual object and compare it
against `data`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
