rdblue commented on code in PR #3610:
URL: https://github.com/apache/parquet-java/pull/3610#discussion_r3562421645
##########
parquet-column/src/test/java/org/apache/parquet/schema/TestPrimitiveComparator.java:
##########
@@ -354,6 +359,60 @@ public void
testBinaryAsSignedIntegerComparatorWithEquals() {
}
}
+ private static Binary int96(int julianDay, long nanosOfDay) {
+ return new NanoTime(julianDay, nanosOfDay).toBinary();
+ }
+
+ private static Binary timestampToInt96(String timestamp) {
+ LocalDateTime dt = LocalDateTime.parse(timestamp);
+ int julianDay = (int) (dt.toLocalDate().toEpochDay() + 2440588);
+ return new NanoTime(julianDay, dt.toLocalTime().toNanoOfDay()).toBinary();
+ }
+
+ @Test
+ public void testInt96TimestampComparator() {
Review Comment:
This also needs to cover cases like negative nanos and nanos >=
86_400_000_000_000. Use a separate test case if the intent is to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
