rdblue commented on code in PR #3610:
URL: https://github.com/apache/parquet-java/pull/3610#discussion_r3562390688
##########
parquet-column/src/test/java/org/apache/parquet/internal/column/columnindex/TestBinaryTruncator.java:
##########
@@ -93,7 +93,16 @@ public void testContractNonStringTypes() {
testTruncator(
Types.required(FIXED_LEN_BYTE_ARRAY).length(12).as(INTERVAL).named("test_fixed_interval"),
false);
testTruncator(Types.required(BINARY).as(DECIMAL).precision(10).scale(2).named("test_binary_decimal"),
false);
- testTruncator(Types.required(INT96).named("test_int96"), false);
+
+ // INT96 has a fixed 12-byte width and a chronological comparator (so it
is excluded from the
+ // variable-length checks above, like FLOAT16). Its truncator is a no-op:
verify it returns the
+ // value unchanged regardless of the requested length.
+ BinaryTruncator int96Truncator = BinaryTruncator.getTruncator(
Review Comment:
This is replacing the INT96 handling above, but this expansion deserves its
own new test case because it is not running the standard `testTrunctator`
logic. This should be in a new `testInt96`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
