Fokko commented on code in PR #3559:
URL: https://github.com/apache/parquet-java/pull/3559#discussion_r3565871063
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java:
##########
@@ -2327,6 +2327,10 @@ public void readFromVectoredRange(ParquetFileRange
currRange, ChunkListBuilder b
LOG.error(error, e);
throw new IOException(error, e);
}
+ // Release the vectored-read buffer back to the allocator when the row
group is closed.
+ // Requires fs.file.checksum.verify=false so the returned buffer is the
allocator buffer
+ // rather than a sliced subset (see Hadoop's fs.file.checksum.verify
docs).
+ builder.addBuffersToRelease(Collections.singletonList(buffer));
Review Comment:
Agreed — if a later range times out or fails, the exception propagates
before `rowGroup.setReleaser(builder.releaser)` runs, so the already-acquired
buffers leak.
Fixed by transferring ownership on the failure path:
- Extracted a `readChunkPagesForBlock(...)` helper (shared by
`internalReadRowGroup` and `internalReadFilteredRowGroup`) that closes
`builder.releaser` if anything throws before ownership is transferred to the
row group.
- In `readVectored`, moved the buffer registration into a `finally` block so
a partially-completed vectored read still registers every buffer it acquired,
ensuring they're released even when a later range fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
