Fokko commented on code in PR #3559: URL: https://github.com/apache/parquet-java/pull/3559#discussion_r4353367078
########## parquet-hadoop/src/test/resources/core-site.xml: ########## @@ -0,0 +1,33 @@ +<?xml version="1.0"?> +<?xml-stylesheet type="text/xsl" href="configuration.xsl"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<configuration> + <property> + <name>fs.file.checksum.verify</name> + <value>false</value> + <description> + Disable checksum verification on the local file system used by tests. + Hadoop's ChecksumFileSystem.readVectored allocates checksum buffers via + the caller-supplied ByteBufferAllocator without releasing them; the + leaked buffers trip TrackingByteBufferAllocator leak detection in tests. + Turning off checksum verification skips the checksum read path entirely + and avoids the leak. Review Comment: This is actually a Hadoop bug, which we should not fix in Parquet: https://issues.apache.org/jira/browse/HADOOP-19901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
