vinooganesh commented on PR #3397: URL: https://github.com/apache/parquet-java/pull/3397#issuecomment-6243577437
@rdblue thanks for the review, and sorry it took me a while to get back to you. I pushed two commits: 2a9a23f8e restructures the reader to follow the spec's sections (plus the renames and static helpers), and 647198fd4 tightens the offset validation. I'm working through the rest of your comments next. I replied on the threads those two commits cover. In one spot I went a different way: I kept the byte-count bound on `:113`, and I explained why there. @wgtmac I opened #3862 and added it to the title. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
