vinooganesh commented on PR #3397: URL: https://github.com/apache/parquet-java/pull/3397#issuecomment-6305801056
@rdblue I pushed the rest of the changes for your comments. You hadn't gotten to the writer, codec and tests yet, so I applied the same feedback there too: the writer now mirrors the reader's structure (a shared base, the spec's order, static helpers), the codec got the same cleanup, and there's a new test that pins the exact bytes the writer produces. I checked byte for byte that the writer's output didn't change. I also replaced the ALP benchmark with encoding-level ones that compare against PLAIN on the same data. Thanks to whoever approved CI — it's green on the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
