rok commented on code in PR #635: URL: https://github.com/apache/parquet-format/pull/635#discussion_r4466520247
########## LogicalTypes.md: ########## @@ -796,10 +800,8 @@ compressed, and encrypted like any other column, `inline` included. does not resolve and is invalid. * `size` must be set whenever `offset` is set. A value that sets `offset` without `size` is invalid. -* If `inline` and a locator are both set, a reader may resolve the value from either. - Producers are expected to write the same bytes in both, but a reader is not required - to check this and may return the bytes of either. Producers may treat `inline` and the - locator fields as mutually exclusive. +* If `inline` is set, it supplies the bytes for readers; producers may treat `inline` and + the locator fields as mutually exclusive. Review Comment: > "inline is a copy of the bytes referenced by the locator at the time the value is written" Yes, I think this is the wording we want. It would indeed not be realistic for parquet writer to guarantee contents of some file system forever. Note that current language is not that far off: "Producers are expected to write the same bytes in both, but a reader is not required to check this and may return the bytes of either." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
