stefan-grafberger commented on code in PR #635: URL: https://github.com/apache/parquet-format/pull/635#discussion_r4458328624
########## LogicalTypes.md: ########## @@ -796,10 +800,8 @@ compressed, and encrypted like any other column, `inline` included. does not resolve and is invalid. * `size` must be set whenever `offset` is set. A value that sets `offset` without `size` is invalid. -* If `inline` and a locator are both set, a reader may resolve the value from either. - Producers are expected to write the same bytes in both, but a reader is not required - to check this and may return the bytes of either. Producers may treat `inline` and the - locator fields as mutually exclusive. +* If `inline` is set, it supplies the bytes for readers; producers may treat `inline` and + the locator fields as mutually exclusive. Review Comment: Thanks! To clarify: the intent isn't to make FILE mutable. The spec already can't prevent the object at uri from changing after the value is written; today, readers may then return either set of bytes. This PR only makes that case consistent between different engines by having readers return the inline bytes as the value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
