[ 
https://issues.apache.org/jira/browse/PHOENIX-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612702#comment-16612702
 ] 

Hadoop QA commented on PHOENIX-4519:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12939439/PHOENIX-4519.patch
  against master branch at commit 2437049b408343255b4d00a2c50b97825df8cb0b.
  ATTACHMENT ID: 12939439

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +    String asyncIndexDDL = "CREATE INDEX " + asyncIndexName + " ON " + 
tableName + " (a.varchar_col1) ASYNC";
+    String needsRebuildIndexDDL = "CREATE INDEX " + needsRebuildIndexName + " 
ON " + tableName + " (a.char_col1)";
+      Assert.assertTrue("Did not return index in REBUILD with an 
ASYNC_REBUILD_TIMESTAMP!", foundNeedsRebuildIndex);
+            + " (" + PhoenixDatabaseMetaData.ASYNC_CREATED_DATE + " " + 
PDate.INSTANCE.getSqlTypeName() + ", "
+            +  PhoenixDatabaseMetaData.ASYNC_REBUILD_TIMESTAMP + " " +  
PLong.INSTANCE.getSqlTypeName() + ") "
+            + PhoenixDatabaseMetaData.INDEX_STATE + " IN ('" + 
PIndexState.BUILDING.getSerializedValue() +

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2034//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2034//console

This message is automatically generated.

> Index rebuild MR jobs not created for "alter index rebuild async" rebuilds
> --------------------------------------------------------------------------
>
>                 Key: PHOENIX-4519
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4519
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Vincent Poon
>            Assignee: Geoffrey Jacoby
>            Priority: Major
>         Attachments: PHOENIX-4519.patch
>
>
> It seems we have two ASYNC flags for index rebuilds:
> ASYNC_CREATED_DATE - when an index is created async
> ASYNC_REBUILD_TIMESTAMP - created by "alter index ... rebuild async"
> The PhoenixMRJobSubmitter only submits MR jobs for the former.  We should 
> also submit jobs for the latter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to