[ 
https://issues.apache.org/jira/browse/PHOENIX-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636310#comment-16636310
 ] 

Vincent Poon commented on PHOENIX-4519:
---------------------------------------

Looking at the code with [~tdsilva] , I'm now actually not sure why this would 
be needed.  My understanding of what's happening here:
You run "alter index rebuild async" , which sets ASYNC_REBUILD_TIMESTAMP.  You 
then run the IndexTool with isPartial=true , which then does a partial rebuild 
from INDEX_DISABLE_TIMESTAMP to ASYNC_REBUILD_TIMESTAMP.  Btw [~gjacoby], to 
make this patch complete, I think when ASYNC_REBUILD_TIMESTAMP is set, you will 
need to pass isPartial=true to the IndexTool.  A while back I filed 
PHOENIX-4703 to do what I think you were looking for with this JIRA.

However, if the index_disable_timestamp is set by an index write failure, then 
the rebuilder thread should do the same anyways.  So I think running the 
IndexTool with partial=true would only help if someone set the 
index_disable_timestamp manually first.  Is that true, [~an...@apache.org] ? 



> Index rebuild MR jobs not created for "alter index rebuild async" rebuilds
> --------------------------------------------------------------------------
>
>                 Key: PHOENIX-4519
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4519
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Vincent Poon
>            Assignee: Geoffrey Jacoby
>            Priority: Major
>             Fix For: 4.15.0, 5.1.0
>
>         Attachments: PHOENIX-4519-v2.patch, PHOENIX-4519-v3.patch, 
> PHOENIX-4519.patch
>
>
> It seems we have two ASYNC flags for index rebuilds:
> ASYNC_CREATED_DATE - when an index is created async
> ASYNC_REBUILD_TIMESTAMP - created by "alter index ... rebuild async"
> The PhoenixMRJobSubmitter only submits MR jobs for the former.  We should 
> also submit jobs for the latter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to