Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/343#discussion_r218503306
  
    --- Diff: bin/phoenix_utils.py ---
    @@ -71,6 +71,7 @@ def setPath():
         PHOENIX_CLIENT_JAR_PATTERN = "phoenix-*-client.jar"
         PHOENIX_THIN_CLIENT_JAR_PATTERN = "phoenix-*-thin-client.jar"
         PHOENIX_QUERYSERVER_JAR_PATTERN = "phoenix-*-queryserver.jar"
    +    PHOENIX_LOADBALANCER_JAR_PATTERN = 
"phoenix-load-balancer-*[!t][!e][!s][!t][!s].jar"
    --- End diff --
    
    I think all of the extra square-brackets are unnecessary here. Wouldn't 
`phoenix-load-balancer-*[!tests].jar` be sufficient?


---

Reply via email to