[
https://issues.apache.org/jira/browse/PHOENIX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619461#comment-16619461
]
ASF GitHub Bot commented on PHOENIX-4892:
-----------------------------------------
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/343#discussion_r218531961
--- Diff: bin/phoenix_utils.py ---
@@ -162,6 +163,13 @@ def setPath():
if phoenix_queryserver_jar == "":
phoenix_queryserver_jar =
findFileInPathWithoutRecursion(PHOENIX_QUERYSERVER_JAR_PATTERN,
os.path.join(current_dir, ".."))
+ global phoenix_loadbalancer_jar
+ phoenix_loadbalancer_jar = find(PHOENIX_LOADBALANCER_JAR_PATTERN,
os.path.join(current_dir, "..", "phoenix-loadbalancer", "target", "*"))
+ if phoenix_loadbalancer_jar == "":
+ phoenix_loadbalancer_jar =
findFileInPathWithoutRecursion(PHOENIX_LOADBALANCER_JAR_PATTERN,
os.path.join(current_dir, "..", "lib"))
--- End diff --
Yes, I understand how the load-balancer is meant to work (I was involved in
the reviews and stipulated it be this way ;)).
I'm trying to point out that the logic you've added here is useless on
master because the jar doesn't exist in the lib directory of the tarball
created by the phoenix-assembly module. Specifically, the following path is
never valid because the JAR is not put there on normal tarball builds of Phoenix
```
findFileInPathWithoutRecursion(PHOENIX_LOADBALANCER_JAR_PATTERN,
os.path.join(current_dir, "..", "lib"))
```
> Unable to start load balancer with queryserver
> ----------------------------------------------
>
> Key: PHOENIX-4892
> URL: https://issues.apache.org/jira/browse/PHOENIX-4892
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.12.0, 4.13.0, 4.13.1, 5.0.0
> Reporter: Vitaliy
> Assignee: Vitaliy
> Priority: Minor
>
> Load balancer can not be started with queryserver, because:
> # Do not specified the path to the load balancer.jar in phoenix_utils.py and
> queryserver.py.
> # Do not specified service for Registry (for ServiceLoader).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
