[ 
https://issues.apache.org/jira/browse/PHOENIX-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629800#comment-16629800
 ] 

Lars Hofhansl commented on PHOENIX-4930:
----------------------------------------

Two comments:
 # helpTestSelectWithSplit is always called with canSeeRowsWrittenDuringSelect 
= true, might as well remove it
 # {{+ assert ((int) Math.pow(2, i+1) <= rowCount);}} should be {{+ assert 
((int) Math.pow(2, i+1) *<* rowCount);}}, right? Otherwise we'd be 
none-the-wiser if we actually do not see more rows.

The behavior is OK, right?

> Add test for a simple SELECT query during a split
> -------------------------------------------------
>
>                 Key: PHOENIX-4930
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4930
>             Project: Phoenix
>          Issue Type: Test
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>            Priority: Major
>             Fix For: 4.15.0, 5.1.0
>
>         Attachments: PHOENIX-4930.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to