Github user ChinmaySKulkarni commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/339#discussion_r222150196
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -797,7 +810,7 @@ private PTable addDerivedColumnsFromAncestors(PTable
table, long timestamp,
if (hasIndexId) {
// add all pk columns of parent tables to indexes
// skip salted column as it will be added from the
base table columns
- startIndex = pTable.getBucketNum() != null ? 1 : 0;
+ int startIndex = pTable.getBucketNum() != null ? 1 : 0;
for (int index=startIndex;
index<pTable.getPKColumns().size(); index++) {
PColumn column = pTable.getPKColumns().get(index);
--- End diff --
Please rename `column` to `pkColumn` to make it easier to understand
---
