[GitHub] phoenix pull request #339: PHOENIX-4855 Continue to write base table column ...

[ChinmaySKulkarni]

Github user ChinmaySKulkarni commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/339#discussion_r222153120
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
 ---
    @@ -3243,20 +3270,31 @@ public MetaDataMutationResult updateMutation(PTable 
table, byte[][] rowKeyMetaDa
                                     addingCol = true;
                                     if (pkCount > FAMILY_NAME_INDEX
                                             && 
rowKeyMetaData[PhoenixDatabaseMetaData.FAMILY_NAME_INDEX].length > 0) {
    +                                byte[] familyName = 
rowKeyMetaData[PhoenixDatabaseMetaData.FAMILY_NAME_INDEX];
    +                                byte[] columnName = 
rowKeyMetaData[PhoenixDatabaseMetaData.COLUMN_NAME_INDEX];
    +                                if (table.getExcludedColumns().contains(
    +                                    
PColumnImpl.createExcludedColumn(newPName(familyName), newPName(columnName), 
0l))) {
    +                                    // if this column was previously 
dropped in a view do not allow adding the column back
    +                                    return new MetaDataMutationResult(
    --- End diff --
    
    Only disallow adding it back if the data type is different instead?


---