[
https://issues.apache.org/jira/browse/PHOENIX-4998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666529#comment-16666529
]
Hadoop QA commented on PHOENIX-4998:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12945973/PHOENIX-4998.patch
against master branch at commit 9f224a18b59fdcc323d661af3b307411c84c4a4c.
ATTACHMENT ID: 12945973
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ // Those Java equivalents of sizeof() in C/C++, mentioned on the
Web, might be overkilled here.
+ + SizedUtil.ARRAY_SIZE + this.gpTimestamps.length *
SizedUtil.LONG_SIZE // gpTimestamps
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.phoenix.jdbc.SecureUserConnectionsTest
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2117//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2117//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2117//console
This message is automatically generated.
> The estimated instance size of GuidePostsInfo doesn't count the last update
> timestamp array
> -------------------------------------------------------------------------------------------
>
> Key: PHOENIX-4998
> URL: https://issues.apache.org/jira/browse/PHOENIX-4998
> Project: Phoenix
> Issue Type: Bug
> Reporter: Bin Shi
> Assignee: Bin Shi
> Priority: Major
> Attachments: PHOENIX-4998.patch
>
>
> GuidePostsCache (implemented Guava Cache) use the estimated instance size of
> GuidePostsInfo as the weight of the cache entry. The bug results in the
> underestimation of the weight of the cache entry.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
