[GitHub] phoenix issue #401: PHOENIX-4996: Refactor PTableImpl to use Builder Pattern

[vincentpoon]

Github user vincentpoon commented on the issue:

    https://github.com/apache/phoenix/pull/401
  
    Instead of passing in override props, why not just return a Builder?
    e.g. instead of 
     `Map<String, Object> overrideProps = new HashMap<>();
            overrideProps.put(PTableImpl.COLUMNS, projectedColumns);
            PTable t = PTableImpl.makePTableFromExisting(table, overrideProps);`
    
    how about something like
    `PTable t = 
PTableImpl.builderFromExisting(table).setColumns(projectedColumns).build();`


---