[
https://issues.apache.org/jira/browse/PHOENIX-5182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787524#comment-16787524
]
Hadoop QA commented on PHOENIX-5182:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12961642/PHOENIX-5182.patch
against master branch at commit 452cfff847b2ed8793ba79ffd6362a7419bf2fec.
ATTACHMENT ID: 12961642
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ChangePermissionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TableDDLPermissionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2404//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2404//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2404//console
This message is automatically generated.
> Deprecate getTotalSum API of the GlobalMetric interface
> -------------------------------------------------------
>
> Key: PHOENIX-5182
> URL: https://issues.apache.org/jira/browse/PHOENIX-5182
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Chinmay Kulkarni
> Assignee: Chinmay Kulkarni
> Priority: Major
> Fix For: 4.13.0, 4.14.0, 4.13.1, 5.0.0, 4.15.0, 4.14.1, 5.1.0
>
> Attachments: PHOENIX-5182.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The GlobalMetric interface has a getTotalSum API which is not of much value.
> The only implementation of this interface GlobalMetricImpl (which is not
> no-op) basically does a getValue for the metric when we call getTotalSum,
> which is confusing. We should deprecate it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
