[ 
https://issues.apache.org/jira/browse/PHOENIX-5182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788535#comment-16788535
 ] 

Hudson commented on PHOENIX-5182:
---------------------------------

FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #2406 (See 
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/2406/])
PHOENIX-5182: Deprecate getTotalSum API of the GlobalMetric interface 
(chinmayskulkarni: rev 26d3734d3c2a05c56e92a0ea09a99fd90059f568)
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/execute/PartialCommitIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsDisabledIT.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetric.java


> Deprecate getTotalSum API of the GlobalMetric interface
> -------------------------------------------------------
>
>                 Key: PHOENIX-5182
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5182
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Chinmay Kulkarni
>            Assignee: Chinmay Kulkarni
>            Priority: Major
>             Fix For: 4.13.0, 4.14.0, 4.13.1, 5.0.0, 4.15.0, 4.14.1, 5.1.0
>
>         Attachments: PHOENIX-5182.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The GlobalMetric interface has a getTotalSum API which is not of much value. 
> The only implementation of this interface GlobalMetricImpl (which is not 
> no-op) basically does a getValue for the metric when we call getTotalSum, 
> which is confusing. We should deprecate it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to