ChinmaySKulkarni commented on issue #458: PHOENIX-5181 support Math sin/cos/tan functions URL: https://github.com/apache/phoenix/pull/458#issuecomment-471083410 @yanxinyi overall looks good. I think the offline discussions we had regarding precision and rounding errors are the main points of concern. Can you add tests that reflect such cases?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
