swaroopak commented on a change in pull request #448: use PreparedStatement
URL: https://github.com/apache/phoenix/pull/448#discussion_r272756710
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/DeleteIT.java
##########
@@ -791,9 +791,12 @@ private void testDeleteCount(boolean autoCommit, Integer
limit) throws Exception
props.setProperty(QueryServices.ENABLE_SERVER_SIDE_MUTATIONS,
allowServerSideMutations);
try (Connection conn = DriverManager.getConnection(getUrl(), props)) {
conn.createStatement().execute(ddl);
- Statement stmt = conn.createStatement();
+ //Statement stmt = conn.createStatement();
+ PreparedStatement preStmt =
conn.prepareStatement("UPSERT INTO " + tableName + " (pk1, v1) VALUES (" + ? +
",'value')");
Review comment:
nit: I would extract the SQL string for readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
