twdsilva commented on a change in pull request #2: PHOENIX-5197: Use
extraOptions to set the configuration for Spark Workers
URL: https://github.com/apache/phoenix-connectors/pull/2#discussion_r273187522
##########
File path:
phoenix-spark/src/main/java/org/apache/phoenix/spark/datasource/v2/reader/PhoenixInputPartitionReader.java
##########
@@ -77,14 +80,15 @@ private QueryPlan getQueryPlan() throws SQLException {
String scn = options.getScn();
String tenantId = options.getTenantId();
String zkUrl = options.getZkUrl();
- Properties overridingProps = new Properties();
+ Properties overridingProps = options.getOverriddenProps();
Review comment:
I think options.getOverriddenProps can never be null here, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
