priyankporwal commented on a change in pull request #499: Phoenix-5272 ALTER
INDEX REBUILD ALL
URL: https://github.com/apache/phoenix/pull/499#discussion_r285706509
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java
##########
@@ -1248,8 +1248,8 @@ public MutationState execute() throws SQLException {
private static class ExecutableAlterIndexStatement extends
AlterIndexStatement implements CompilableStatement {
- public ExecutableAlterIndexStatement(NamedTableNode indexTableNode,
String dataTableName, boolean ifExists, PIndexState state, boolean async,
ListMultimap<String,Pair<String,Object>> props) {
- super(indexTableNode, dataTableName, ifExists, state, async,
props);
+ public ExecutableAlterIndexStatement(NamedTableNode indexTableNode,
String dataTableName, boolean ifExists, PIndexState state, boolean isAll,
boolean async, ListMultimap<String,Pair<String,Object>> props) {
+ super(indexTableNode, dataTableName, ifExists, state, isAll,
async, props);
Review comment:
Let's keep the param name in-sync between the jdbc classes and the parser
classes - isAll here and isRebuildAll below. Let's pick one. I'd suggest
'rebuildAll' (to keep it consistent everywhere and inline with async without
[is]).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
