[
https://issues.apache.org/jira/browse/PHOENIX-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867073#comment-16867073
]
Hadoop QA commented on PHOENIX-5211:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12972131/PHOENIX-5211.patch
against master branch at commit 56e0f0381fe30005f3cdd1718f99f3205e56d99e.
ATTACHMENT ID: 12972131
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 2 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ private void
createAndPopulateTableAndIndexForConsistentIndex(Connection conn, String
tableName, String indexName, int numOfRowsToInsert)
+ rs = conn.createStatement().executeQuery("SELECT /*+ NO_INDEX */
COUNT(*) FROM " + TABLE_NAME);
+ assertEquals(true, verifyRowsForEmptyColValue(conn, fullIndexName,
IndexRegionObserver.VERIFIED_BYTES));
+ try (Admin admin =
conn.unwrap(PhoenixConnection.class).getQueryServices().getAdmin();) {
+ createAndPopulateTableAndIndexForConsistentIndex(conn,
fullTableName, fullIndexName, numRows);
+ rs = conn.createStatement().executeQuery("SELECT /*+ NO_INDEX */
COUNT(*) FROM " + TABLE_NAME);
+ // Force delete to fail (data removed but operation failed) on
data table and check index table row remains as unverified
+ assertEquals(numRows - 1,
getRawRowCount(conn.unwrap(PhoenixConnection.class).getQueryServices()
+ assertEquals(true, verifyRowsForEmptyColValue(conn, fullIndexName,
IndexRegionObserver.UNVERIFIED_BYTES));
+ String selectFromIndex = "SELECT long_pk, varchar_pk, long_col1
FROM " + TABLE_NAME + " WHERE varchar_pk='varchar2' AND long_pk=2";
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.SaltedIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.RowTimestampIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.LocalIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.IndexWithTableSchemaChangeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolForPartialBuildIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.RegexBulkLoadToolIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.IndexUsageIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.RowValueConstructorIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpsertSelectIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.IndexMetadataIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ViewIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolForPartialBuildWithNamespaceEnabledIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ChildViewsUseParentViewIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.GlobalImmutableNonTxIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.CsvBulkLoadToolIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexExtendedIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DistinctPrefixFilterIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.monitoring.PhoenixMetricsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DeleteIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2685//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2685//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2685//console
This message is automatically generated.
> Consistent Immutable Global Indexes for Non-Transactional Tables
> ----------------------------------------------------------------
>
> Key: PHOENIX-5211
> URL: https://issues.apache.org/jira/browse/PHOENIX-5211
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.13.0, 4.14.0, 5.0.0, 4.14.1
> Reporter: Kadir OZDEMIR
> Assignee: Gokcen Iskender
> Priority: Major
> Attachments: PHOENIX-5122-4.x-1.4.patch, PHOENIX-5211.patch
>
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
> Without transactional tables, the immutable global indexes can get easily out
> of sync with their data tables in Phoenix. Transactional tables require a
> separate transaction manager, have some restrictions and performance
> penalties. This issue is to have consistent immutable global indexes without
> the need for using transactional tables.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
