[
https://issues.apache.org/jira/browse/PHOENIX-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875883#comment-16875883
]
Hadoop QA commented on PHOENIX-5211:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12973290/PHOENIX-5211.master.003.patch
against master branch at commit 31daa0917c534cbcfb160ec212d5fa839f7df584.
ATTACHMENT ID: 12973290
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ PTable pindexTable = PhoenixRuntime.getTable(conn,
SchemaUtil.getTableName(schemaName, indxTable));
+ // Due to PHOENIX-5375 and PHOENIX-5376, the
snapshot and bulk load options are ignored for global indexes
+ private void createAndPopulateTableAndIndexForConsistentIndex(Connection
conn, String tableName, String indexName,
+ String fullTableName =
SchemaUtil.getTableName(TestUtil.DEFAULT_SCHEMA_NAME, tableName);
+ String fullIndexName =
SchemaUtil.getTableName(TestUtil.DEFAULT_SCHEMA_NAME, indexName);
+ rs = conn.createStatement().executeQuery("SELECT /*+ NO_INDEX
*/ COUNT(*) FROM " + TABLE_NAME);
+ try (Admin admin =
conn.unwrap(PhoenixConnection.class).getQueryServices().getAdmin();) {
+ createAndPopulateTableAndIndexForConsistentIndex(conn,
fullTableName, fullIndexName, numRows, null);
+ rs = conn.createStatement().executeQuery("SELECT /*+ NO_INDEX */
COUNT(*) FROM " + TABLE_NAME);
+ assertEquals(true, verifyRowsForEmptyColValue(conn, fullIndexName,
IndexRegionObserver.VERIFIED_BYTES));
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2721//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/2721//console
This message is automatically generated.
> Consistent Immutable Global Indexes for Non-Transactional Tables
> ----------------------------------------------------------------
>
> Key: PHOENIX-5211
> URL: https://issues.apache.org/jira/browse/PHOENIX-5211
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.13.0, 4.14.0, 5.0.0, 4.14.1
> Reporter: Kadir OZDEMIR
> Assignee: Gokcen Iskender
> Priority: Major
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-5211.4.x-HBase-1.3.001.patch,
> PHOENIX-5211.master.002.patch, PHOENIX-5211.master.003.patch,
> PHOENIX-5211.master.004.patch, PHOENIX-5211.patch
>
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
> Without transactional tables, the immutable global indexes can get easily out
> of sync with their data tables in Phoenix. Transactional tables require a
> separate transaction manager, have some restrictions and performance
> penalties. This issue is to have consistent immutable global indexes without
> the need for using transactional tables.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
