kadirozde commented on a change in pull request #652: PHOENIX-5615 Index read
repair should delete all the cells of an inva…
URL: https://github.com/apache/phoenix/pull/652#discussion_r357315105
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java
##########
@@ -245,6 +247,14 @@ private void deleteRowIfAgedEnough(byte[] indexRowKey,
List<Cell> row, long ts,
if ((EnvironmentEdgeManager.currentTimeMillis() - ts) >
ageThreshold) {
Delete del = new Delete(indexRowKey, ts);
if (specific) {
+ // Get all the cells of this row
+ deleteRowScan.withStartRow(indexRowKey, true);
Review comment:
It is safer to retrieve the columns to find out their timestamps and delete
markers for these timestamps, at least for now. We can think about your
suggestion in future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
