[
https://issues.apache.org/jira/browse/PHOENIX-5537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034895#comment-17034895
]
Hadoop QA commented on PHOENIX-5537:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12993141/PHOENIX-5537.master.v1.patch
against master branch at commit 9fb24b3971dcc288aff7858d25285cfb4906cc4e.
ATTACHMENT ID: 12993141
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public static MetricsStopWatch getMetricsStopWatch(boolean
isRequestMetricsEnabled, LogLevel connectionLogLevel, MetricType type) {
+ if(!type.isLoggingEnabled(connectionLogLevel) &&
!isRequestMetricsEnabled){ return new MetricsStopWatch(false); }
+ queryWatch =
MetricUtil.getMetricsStopWatch(isRequestMetricsEnabled,connectionLogLevel,
WALL_CLOCK_TIME_MS);
+ resultSetWatch =
MetricUtil.getMetricsStopWatch(isRequestMetricsEnabled,connectionLogLevel,
RESULT_SET_TIME_MS);
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3426//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3426//console
This message is automatically generated.
> Phoenix-4701 made hard coupling between phoenix.log.level and getting request
> metrics.
> --------------------------------------------------------------------------------------
>
> Key: PHOENIX-5537
> URL: https://issues.apache.org/jira/browse/PHOENIX-5537
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Daniel Wong
> Assignee: Richard Antal
> Priority: Minor
> Fix For: 5.1.0, 4.15.1, 4.16.0
>
> Attachments: PHOENIX-5537.master.v1.patch
>
>
> Phoenix-4701 made hard coupling between phoenix.log.level and getting request
> metrics. For users who do not want to enable system to log this causes a
> regression from earlier behavior where metrics were populated. FYI [~ankit]
> {code:java}
> public OverAllQueryMetrics(boolean isRequestMetricsEnabled, LogLevel
> connectionLogLevel) { public OverAllQueryMetrics(boolean
> isRequestMetricsEnabled, LogLevel connectionLogLevel) { queryWatch = new
> MetricsStopWatch(WALL_CLOCK_TIME_MS.isLoggingEnabled(connectionLogLevel));
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
