gokceni commented on a change in pull request #743: PHOENIX-5798 IndexUpgrade
tool command line improvements
URL: https://github.com/apache/phoenix/pull/743#discussion_r397990857
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
##########
@@ -98,16 +98,14 @@
private static final Option LOG_FILE_OPTION = new Option("lf", "logfile",
true,
"[Optional] Log file path where the logs are written");
- private static final Option INDEX_SYNC_REBUILD_OPTION = new Option("sr",
- "index-sync-rebuild",
+ private static final Option INDEX_REBUILD_OPTION = new Option("rb",
+ "index-rebuild",
false,
- "[Optional] Whether or not synchronously rebuild the indexes; "
- + "default rebuild asynchronous");
-
- private static final Option INDEX_VERIFY_OPTION = new Option("v",
- "verify",
+ "[Optional] Rebuild the indexes");
Review comment:
Can you change this description to include that the indexToolOption is tied
to this one? And vice versa
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
