joshelser commented on issue #25: PHOENIX-5827 Add a maven repo to PQS
URL: 
https://github.com/apache/phoenix-queryserver/pull/25#issuecomment-611584928
 
 
   > Given that the PQS server artifact is supposed to be phoenix and HBase 
version agnostic I think that we should not add the thick client repo to the 
assembly by default.
   
   So, this is how I would call PQS broken right now. The assembly it creates 
is useless. PQS requires a phoenix-client jar, we don't provide one, and we 
don't give any indication that you have to include one.
   
   We have a dependency on a version of Phoenix yes, but the ability to set 
`-Dphoenix.version` (and `-D phoenix.hbase.classifier=..` if you're going 
against your HBase profile work in 5.x) which lets a user build a "proper" 
assembly for their own use-cases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to