stoty commented on a change in pull request #25: PHOENIX-5827 Add a maven repo
to PQS
URL: https://github.com/apache/phoenix-queryserver/pull/25#discussion_r407941101
##########
File path: assembly/pom.xml
##########
@@ -74,7 +73,38 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <!-- Create a mini Maven repository so PQS can serve these
jars like a Maven repo -->
+ <execution>
+ <id>prepare-client-repo</id>
+ <!-- Make sure we build this before making the assembly -->
+ <phase>prepare-package</phase>
+ <goals>
+ <goal>copy-dependencies</goal>
+ </goals>
+ <configuration>
+
<includeArtifactIds>phoenix-client,queryserver-client</includeArtifactIds>
+
<outputDirectory>${project.build.directory}/maven-repo</outputDirectory>
+ <overWriteIfNewer>true</overWriteIfNewer>
+ <useRepositoryLayout>true</useRepositoryLayout>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <id>package-phoenix-client</id>
Review comment:
Maybe let this be activated by a system property as well, for consistency ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
