[
https://issues.apache.org/jira/browse/PHOENIX-5891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106827#comment-17106827
]
Hadoop QA commented on PHOENIX-5891:
------------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13002871/PHOENIX-5891-master-v1.patch
against master branch at commit 753895fda79da19cd35e098e63abcab7310ca204.
ATTACHMENT ID: 13002871
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation, build,
or dev patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3853//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3853//artifact/phoenix-core/target/site/jacoco/index.html
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3853//console
This message is automatically generated.
> Ensure that code coverage does not drop with subsequent commits
> ---------------------------------------------------------------
>
> Key: PHOENIX-5891
> URL: https://issues.apache.org/jira/browse/PHOENIX-5891
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0, 4.14.3
> Reporter: Chinmay Kulkarni
> Assignee: Chinmay Kulkarni
> Priority: Major
> Labels: quality-improvement
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5891-master-v1.patch
>
>
> With [PHOENIX-5842|https://issues.apache.org/jira/browse/PHOENIX-5842], we
> added Jacoco code coverage to Hadoop QA precommit runs. We should add a check
> to test-patch.sh to ensure that the code coverage numbers do not drop when
> applying a new patch.
> This can also check that overall code coverage is above a fixed threshold as
> well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
