[
https://issues.apache.org/jira/browse/PHOENIX-5891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106934#comment-17106934
]
Sandeep Guggilam commented on PHOENIX-5891:
-------------------------------------------
[~ckulkarni] The patch looks good to me
> Ensure that code coverage does not drop with subsequent commits
> ---------------------------------------------------------------
>
> Key: PHOENIX-5891
> URL: https://issues.apache.org/jira/browse/PHOENIX-5891
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0, 4.14.3
> Reporter: Chinmay Kulkarni
> Assignee: Chinmay Kulkarni
> Priority: Major
> Labels: quality-improvement
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5891-master-v1.patch
>
>
> With [PHOENIX-5842|https://issues.apache.org/jira/browse/PHOENIX-5842], we
> added Jacoco code coverage to Hadoop QA precommit runs. We should add a check
> to test-patch.sh to ensure that the code coverage numbers do not drop when
> applying a new patch.
> This can also check that overall code coverage is above a fixed threshold as
> well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
