stoty commented on pull request #32: URL: https://github.com/apache/phoenix-queryserver/pull/32#issuecomment-628487224
Thanks for the thorough review. Re the shutdown problem: This didn't happen during my testing (or at least it was hidden by the test framework) Could you open a JIRA for this with your repro code ? I do not see anything obviously bad with the code. Re ORM: I have not even attempted to make that work, as it is not present in the pyphoenix implementation, and is not used by Hue. Even if it's possible to add, it looks like far more work than what I have budgeted for PhoenixDB ATM. Re read-only: Writing should be possible via textual sql (i.e. bypassing ORM). There was an error with the autocommit implementation, but I have fixed it now. I have also added a rudimentary test case for textual upsert/autocommit/select. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
