[
https://issues.apache.org/jira/browse/PHOENIX-5897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108249#comment-17108249
]
Hadoop QA commented on PHOENIX-5897:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13003008/PHOENIX-5897-v1.patch
against master branch at commit 49599fd89b6cfa9cab9d7d3f6dcf4bdc5428915a.
ATTACHMENT ID: 13003008
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3857//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3857//artifact/phoenix-core/target/site/jacoco/index.html
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3857//console
This message is automatically generated.
> SingleKeyValueTuple.toString() returns unexpected result
> --------------------------------------------------------
>
> Key: PHOENIX-5897
> URL: https://issues.apache.org/jira/browse/PHOENIX-5897
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0-alpha
> Reporter: Chen Feng
> Assignee: Chen Feng
> Priority: Minor
> Fix For: 5.1.0
>
> Attachments: PHOENIX-5897-v1.patch
>
>
> In SingleKeyValueTuple.toString(), the code is shown as follows.
> return "SingleKeyValueTuple[" + cell == null ? keyPtr.get() ==
> UNITIALIZED_KEY_BUFFER ? "null" :
> Bytes.toStringBinary(keyPtr.get(),keyPtr.getOffset(),keyPtr.getLength()) :
> cell.toString() + "]";
> actually, the code runs in the following order.
> ("SingleKeyValueTuple[" + cell) == null ? keyPtr.get() ==
> UNITIALIZED_KEY_BUFFER ? "null" : Bytes.toStringBinary() : (cell.toString() +
> "]");
> Therefore the result is weird.
> BTW, value = condition1 ? condition2 ? X : Y : Z is also confusing, using if
> can be more clear.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
