[
https://issues.apache.org/jira/browse/PHOENIX-5897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141452#comment-17141452
]
Hadoop QA commented on PHOENIX-5897:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13006134/PHOENIX-5897_v1-4.x.patch
against 4.x branch at commit e41fc51507ea17c73b519e3d5b574f97c4f567f0.
ATTACHMENT ID: 13006134
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3983//console
This message is automatically generated.
> SingleKeyValueTuple.toString() returns unexpected result
> --------------------------------------------------------
>
> Key: PHOENIX-5897
> URL: https://issues.apache.org/jira/browse/PHOENIX-5897
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0-alpha
> Reporter: Chen Feng
> Assignee: Chen Feng
> Priority: Minor
> Fix For: 5.1.0
>
> Attachments: PHOENIX-5897-v1.patch, PHOENIX-5897_v1-4.x.patch
>
>
> In SingleKeyValueTuple.toString(), the code is shown as follows.
> return "SingleKeyValueTuple[" + cell == null ? keyPtr.get() ==
> UNITIALIZED_KEY_BUFFER ? "null" :
> Bytes.toStringBinary(keyPtr.get(),keyPtr.getOffset(),keyPtr.getLength()) :
> cell.toString() + "]";
> actually, the code runs in the following order.
> ("SingleKeyValueTuple[" + cell) == null ? keyPtr.get() ==
> UNITIALIZED_KEY_BUFFER ? "null" : Bytes.toStringBinary() : (cell.toString() +
> "]");
> Therefore the result is weird.
> BTW, value = condition1 ? condition2 ? X : Y : Z is also confusing, using if
> can be more clear.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
