[ 
https://issues.apache.org/jira/browse/PHOENIX-5422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165554#comment-17165554
 ] 

Hadoop QA commented on PHOENIX-5422:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/13008475/PHOENIX-5422.master.v2.patch
  against master branch at commit ce83d74050a8cc1637068f3fb8980e14f9bde611.
  ATTACHMENT ID: 13008475

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 0 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.phoenix.util.DateUtilTest

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4079//testReport/
Code Coverage results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4079//artifact/phoenix-core/target/site/jacoco/index.html
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4079//console

This message is automatically generated.

> Use Java8 DateTime APIs instead of joda-time APIs
> -------------------------------------------------
>
>                 Key: PHOENIX-5422
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5422
>             Project: Phoenix
>          Issue Type: Task
>    Affects Versions: 4.8.0
>            Reporter: Naveen Gangam
>            Assignee: Richard Antal
>            Priority: Minor
>         Attachments: PHOENIX-5422.master.v1.patch, 
> PHOENIX-5422.master.v2.patch
>
>
> currently, phoenix-hive.jar bundles an old version of joda-time library. 
> Java8 has new DateTime APIs are similar in to the joda-time APIs in features. 
> It would make sense to eliminate a dependency on external library that may or 
> may not be
> a) Actively developed
> b) not guaranteed to be backward compatible with older APIs and could involve 
> code changes as well.
> Its is better to move using JDK8 APIs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to