[ 
https://issues.apache.org/jira/browse/PHOENIX-5422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166250#comment-17166250
 ] 

Richard Antal commented on PHOENIX-5422:
----------------------------------------

I revisited the failing tests and found out that joda time was less strict in 
terms of the date / time formats.
 Joda time supported YYYY-M-D formats but, ISO_DATE in java time only supports 
standard YYYY-MM-DD format strictly.
Date from the year and week number can not be created without the day number in 
the week in Java time.
There is a difference also in the Timestamp initial value, In joda time it was 
the nano secs, but in Java Timestamp it required milliseconds.

I think we should properly document these changes.

> Use Java8 DateTime APIs instead of joda-time APIs
> -------------------------------------------------
>
>                 Key: PHOENIX-5422
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5422
>             Project: Phoenix
>          Issue Type: Task
>    Affects Versions: 4.8.0
>            Reporter: Naveen Gangam
>            Assignee: Richard Antal
>            Priority: Minor
>         Attachments: PHOENIX-5422.master.v1.patch, 
> PHOENIX-5422.master.v2.patch, PHOENIX-5422.master.v3.patch, 
> PHOENIX-5422.master.v4.patch
>
>
> currently, phoenix-hive.jar bundles an old version of joda-time library. 
> Java8 has new DateTime APIs are similar in to the joda-time APIs in features. 
> It would make sense to eliminate a dependency on external library that may or 
> may not be
> a) Actively developed
> b) not guaranteed to be backward compatible with older APIs and could involve 
> code changes as well.
> Its is better to move using JDK8 APIs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to