stoty commented on a change in pull request #25: URL: https://github.com/apache/phoenix-connectors/pull/25#discussion_r466833722
########## File path: phoenix5-compat/pom.xml ########## @@ -0,0 +1,83 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <groupId>org.apache</groupId> + <artifactId>apache</artifactId> + <version>14</version> + </parent> + <modelVersion>4.0.0</modelVersion> + <version>6.0.0-SNAPSHOT</version> + + <groupId>org.apache.phoenix</groupId> + <artifactId>Phoenix5-compat</artifactId> Review comment: Please use lowercase artifactIds. ########## File path: phoenix5-compat/src/main/java/org/apache/phoenix/compat/CompatUtil.java ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.compat; + +import org.apache.hadoop.hbase.HRegionLocation; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.client.Admin; +import org.apache.hadoop.hbase.client.RegionLocator; +import org.apache.hadoop.hbase.mapreduce.RegionSizeCalculator; +import org.junit.Assert; + +import java.io.IOException; + +public class CompatUtil { + + private CompatUtil() { + // Not to be instantiated + } + + public static void assertTableExists(Admin admin, String fullTableName) Review comment: This pulls in Junit as a compile time dependency, which we do not want (as it would mean that all connectors pull in Junit unnecessarily). I think converting it simply to boolean tableExists() would solve that. ########## File path: phoenix4-compat/pom.xml ########## @@ -0,0 +1,83 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <groupId>org.apache</groupId> + <artifactId>apache</artifactId> + <version>14</version> + </parent> + <modelVersion>4.0.0</modelVersion> + <version>6.0.0-SNAPSHOT</version> + + <groupId>org.apache.phoenix</groupId> + <artifactId>Phoenix4-compat</artifactId> + + <properties> + <phoenix.version>4.15.0-HBase-1.4</phoenix.version> + <hbase.version>1.4.0</hbase.version> + <junit.version>4.12</junit.version> + </properties> + + <build> + <plugins> + <!-- Setup eclipse --> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-eclipse-plugin</artifactId> + <version>2.9</version> + <configuration> + <buildcommands> + <buildcommand>org.eclipse.jdt.core.javabuilder</buildcommand> + </buildcommands> + </configuration> + </plugin> + <plugin> + <groupId>org.apache.rat</groupId> + <artifactId>apache-rat-plugin</artifactId> + </plugin> + </plugins> + </build> + + <dependencies> + <!-- HBase dependencies --> + <dependency> + <groupId>org.apache.hbase</groupId> + <artifactId>hbase-client</artifactId> + <version>${hbase.version}</version> + <scope>provided</scope> + </dependency> + <dependency> + <groupId>org.apache.hbase</groupId> + <artifactId>hbase-common</artifactId> + <version>${hbase.version}</version> + <scope>provided</scope> + </dependency> + <dependency> + <groupId>org.apache.hbase</groupId> + <artifactId>hbase-server</artifactId> + <version>${hbase.version}</version> + </dependency> + + <!-- Test dependencies --> Review comment: See comment in java code ########## File path: phoenix-flume-base/phoenix5-flume/pom.xml ########## @@ -0,0 +1,28 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <artifactId>phoenix-flume-base</artifactId> + <groupId>org.apache.phoenix</groupId> + <version>6.0.0-SNAPSHOT</version> + </parent> + <modelVersion>4.0.0</modelVersion> + + <artifactId>phoenix5-flume</artifactId> + <name>Phoenix5 - Flume</name> + + <properties> + <top.dir>${project.basedir}/..</top.dir> + <phoenix.version>5.1.0-SNAPSHOT</phoenix.version> + <hbase.version>2.2.4</hbase.version> Review comment: Could you do this ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
