[ 
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199815#comment-17199815
 ] 

Xinyi Yan commented on PHOENIX-5712:
------------------------------------

Hi [~larsh], I still not sure how to solve the second part of the problem with 
your approach, can you elaborate more about  "Care must be take to not do this 
internally (in MetadataClientImpl)" here.

When I tried to debug and attached the process from my sqlline client, the 
syscat cached metadata locally and the ExpressionProject column showed 
VIEW_INDEX_ID as a BIGINT, and I don't think change ExpressionProject because 
we want to convert per row just for thi

One way that I can think of is hacky, but it works. I check the table and 
column names inside the getObject(PhoenixResultSet ) method and the actual ptr 
value size. If the ExpressionProjector(VIEW_INDEX_ID) has a dataType BIGINT 
with ptr size 3(short + separator) or SMALLINT with ptr size 9, we do the 
conversion.

I have been verified the upgrade from 4.14 to 4.16 and checked ts has phoenix 
version value. Fetching query view_index_id from the syscat with old/new client 
create view. index, with/without view_index_id_data_type works as expected.

I have uploaded a draft patch, feel free to add comments. cc [~ckulkarni]  

!Screen Shot 2020-09-21 at 10.18.08 PM.png!

 

!Screen Shot 2020-09-21 at 10.13.17 PM.png!

> Got SYSCAT  ILLEGAL_DATA exception after created tenant index on view
> ---------------------------------------------------------------------
>
>                 Key: PHOENIX-5712
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5712
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.15.0
>            Reporter: Xinyi Yan
>            Assignee: Xinyi Yan
>            Priority: Blocker
>             Fix For: 5.1.0, 4.16.0
>
>         Attachments: 5712-WIP.txt, 5712-test.txt, Screen Shot 2020-09-21 at 
> 10.13.17 PM.png, Screen Shot 2020-09-21 at 10.18.08 PM.png, t.txt
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> repo
> //create a multi-tenant table on global connection
> CREATE TABLE A (TENANT_ID CHAR(15) NOT NULL, ID CHAR(3) NOT NULL, NUM BIGINT 
> CONSTRAINT PK PRIMARY KEY (TENANT_ID, ID)) MULTI_TENANT = true;
> // create view and index on tenant connection
> CREATE VIEW A_VIEW AS SELECT * FROM A;
> UPSERT INTO A_VIEW (ID, NUM) VALUES ('A', 1);
> CREATE INDEX A_VIEW_INDEX ON A_VIEW (NUM DESC) INCLUDE (ID);
> // qeury data on global connection 
> SELECT * RFOM SYSTEM.CATALOG;
> {code:java}
> Error: ERROR 201 (22000): Illegal data. Expected length of at least 8 bytes, 
> but had 3 (state=22000,code=201)
> java.sql.SQLException: ERROR 201 (22000): Illegal data. Expected length of at 
> least 8 bytes, but had 3
>         at 
> org.apache.phoenix.exception.SQLExceptionCode$Factory$1.newException(SQLExceptionCode.java:559)
>         at 
> org.apache.phoenix.exception.SQLExceptionInfo.buildException(SQLExceptionInfo.java:195)
>         at 
> org.apache.phoenix.schema.types.PDataType.checkForSufficientLength(PDataType.java:290)
>         at 
> org.apache.phoenix.schema.types.PLong$LongCodec.decodeLong(PLong.java:256)
>         at org.apache.phoenix.schema.types.PLong.toObject(PLong.java:115)
>         at org.apache.phoenix.schema.types.PLong.toObject(PLong.java:31)
>         at 
> org.apache.phoenix.schema.types.PDataType.toObject(PDataType.java:1011)
>         at 
> org.apache.phoenix.compile.ExpressionProjector.getValue(ExpressionProjector.java:75)
>         at 
> org.apache.phoenix.jdbc.PhoenixResultSet.getObject(PhoenixResultSet.java:585)
>         at sqlline.Rows$Row.<init>(Rows.java:258)
>         at sqlline.BufferedRows.nextList(BufferedRows.java:111)
>         at sqlline.BufferedRows.<init>(BufferedRows.java:52)
>         at sqlline.SqlLine.print(SqlLine.java:1623)
>         at sqlline.Commands.execute(Commands.java:982)
>         at sqlline.Commands.sql(Commands.java:906)
>         at sqlline.SqlLine.dispatch(SqlLine.java:740)
>         at sqlline.SqlLine.begin(SqlLine.java:557)
>         at sqlline.SqlLine.start(SqlLine.java:270)
>         at sqlline.SqlLine.main(SqlLine.java:201)
> {code}
> I tried to drop the view, and I was able to query the data from the SYSCATA. 
> I tested on 4.x-HBase1.3 and master branch, all branches have the same 
> behavior.
>  
> cc [~kadir] [~gjacoby] [~swaroopa]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to