richardantal commented on pull request #32: URL: https://github.com/apache/phoenix-connectors/pull/32#issuecomment-703538907
I see that most of this change has been copied from Phoenix core, it seems to be well adapted to Phoenix-connectors. I found some comments that could be updated as well, in dev/jenkins_precommit_github_yetus.sh line num 71 and dev/phoenix-connectors-personality.sh 142, 143? 207, 232, 253. Otherwise this change looks good to me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
