[
https://issues.apache.org/jira/browse/PHOENIX-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210003#comment-17210003
]
ASF GitHub Bot commented on PHOENIX-6181:
-----------------------------------------
stoty commented on pull request #915:
URL: https://github.com/apache/phoenix/pull/915#issuecomment-705327370
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 24s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
2 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 39s | 4.x passed |
| +1 :green_heart: | compile | 0m 53s | 4.x passed |
| +1 :green_heart: | checkstyle | 1m 13s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 45s | 4.x passed |
| +0 :ok: | spotbugs | 2m 54s | phoenix-core in 4.x has 957 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 54s | the patch passed |
| +1 :green_heart: | compile | 0m 56s | the patch passed |
| +1 :green_heart: | javac | 0m 56s | the patch passed |
| -1 :x: | checkstyle | 1m 21s | phoenix-core: The patch generated 542
new + 1433 unchanged - 372 fixed = 1975 total (was 1805) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 41s | the patch passed |
| -1 :x: | spotbugs | 3m 3s | phoenix-core generated 1 new + 956
unchanged - 1 fixed = 957 total (was 957) |
||| _ Other Tests _ |
| -1 :x: | unit | 1m 12s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 10s | The patch does not generate
ASF License warnings. |
| | | 34m 35s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| |
org.apache.phoenix.coprocessor.GlobalIndexRegionScanner.shouldVerify(IndexTool$IndexVerifyType,
byte[], Scan, Region, IndexMaintainer, IndexVerificationResultRepository,
boolean) may expose internal representation by storing an externally mutable
object into GlobalIndexRegionScanner.indexRowKeyforReadRepair At
GlobalIndexRegionScanner.java:IndexVerificationResultRepository, boolean) may
expose internal representation by storing an externally mutable object into
GlobalIndexRegionScanner.indexRowKeyforReadRepair At
GlobalIndexRegionScanner.java:[line 328] |
| Failed junit tests | phoenix.index.ShouldVerifyTest |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/915 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux b294a7ca6906 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 3008ca9 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/1/testReport/
|
| Max. process+thread count | 487 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-915/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> IndexRepairRegionScanner to verify and repair every global index row
> --------------------------------------------------------------------
>
> Key: PHOENIX-6181
> URL: https://issues.apache.org/jira/browse/PHOENIX-6181
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.14.3
> Reporter: Kadir OZDEMIR
> Assignee: Kadir OZDEMIR
> Priority: Major
> Attachments: PHOENIX-6181.4.x.001.patch
>
>
> IndexRebuildRegionScanner is the server side engine to rebuild and verify
> every index row pointed by the data table. IndexRebuildRegionScanner runs on
> data table regions and scans every data table rows locally, and then rebuilds
> and verifies index table rows referenced by the data table rows over
> server-to-server RPCs using the HBase client installed on region servers.
> However, IndexRebuildRegionScanner cannot clean up the index rows that are
> not referenced by the data table if there are such index rows. In order to do
> that we need another region scanner that scans index table regions and makes
> sure that every index row is valid. This region scanner will be called
> IndexRepairRegionScanner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
