[
https://issues.apache.org/jira/browse/PHOENIX-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213453#comment-17213453
]
ASF GitHub Bot commented on PHOENIX-6185:
-----------------------------------------
stoty commented on pull request #919:
URL: https://github.com/apache/phoenix/pull/919#issuecomment-708038035
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 9s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 45m 8s | master passed |
| +1 :green_heart: | compile | 1m 2s | master passed |
| +1 :green_heart: | checkstyle | 0m 39s | master passed |
| +1 :green_heart: | javadoc | 0m 48s | master passed |
| +0 :ok: | spotbugs | 3m 7s | phoenix-core in master has 973 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 42m 2s | the patch passed |
| +1 :green_heart: | compile | 0m 57s | the patch passed |
| +1 :green_heart: | javac | 0m 57s | the patch passed |
| -1 :x: | checkstyle | 0m 40s | phoenix-core: The patch generated 3
new + 580 unchanged - 1 fixed = 583 total (was 581) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 48s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 18s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 123m 21s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 22s | The patch does not generate
ASF License warnings. |
| | | 225m 43s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.UpgradeIT |
| | phoenix.end2end.ConcurrentMutationsExtendedIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-919/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/919 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux ebfb4a51b34f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / b4afc08 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-919/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-919/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-919/1/testReport/
|
| Max. process+thread count | 6152 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-919/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> OPERATION_TIMED_OUT#newException method swallows the exception message and
> root cause exception.
> ------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6185
> URL: https://issues.apache.org/jira/browse/PHOENIX-6185
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Affects Versions: 4.14.3
> Reporter: Rushabh Shah
> Assignee: Viraj Jasani
> Priority: Major
>
> BaseResultIterators#getIterators encountered TimeoutException
> [here|https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java#L1383-L1389]
> {code:java}
> } catch (TimeoutException e) {
> context.getOverallQueryMetrics().queryTimedOut();
> GLOBAL_QUERY_TIMEOUT_COUNTER.increment();
> // thrown when a thread times out waiting for the future.get()
> call to return
> toThrow = new SQLExceptionInfo.Builder(OPERATION_TIMED_OUT)
> .setMessage(". Query couldn't be completed in the
> allotted time: "
> + queryTimeOut + "
> ms").setRootCause(e).build().buildException();
> {code}
> It creates SQLExceptionInfo object with message indicating the timeout and
> the root cause exception.
> But
> [SQLExceptionCode#OPERATION_TIMED_OUT#newException|https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L453-L459]
> ignores all that information and creates SQLException with just template
> message and loses the root cause exception also.
> {code:java}
> OPERATION_TIMED_OUT(6000, "TIM01", "Operation timed out.", new Factory() {
> @Override
> public SQLException newException(SQLExceptionInfo info) {
> return new SQLTimeoutException(OPERATION_TIMED_OUT.getMessage(),
> OPERATION_TIMED_OUT.getSQLState(),
> OPERATION_TIMED_OUT.getErrorCode());
> }
> }),
> {code}
> Instead it should create SQLTimeoutException from SQLExceptionInfo object.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
