[
https://issues.apache.org/jira/browse/PHOENIX-6189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215701#comment-17215701
]
ASF GitHub Bot commented on PHOENIX-6189:
-----------------------------------------
ntshmah commented on a change in pull request #924:
URL: https://github.com/apache/phoenix/pull/924#discussion_r506773406
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/exception/DataExceedsCapacityException.java
##########
@@ -31,11 +31,26 @@ public DataExceedsCapacityException(String message) {
SQLExceptionCode.DATA_EXCEEDS_MAX_CAPACITY).setMessage(message).build().buildException());
}
+ @Deprecated
public DataExceedsCapacityException(PDataType type, Integer precision,
Integer scale, String columnName, ImmutableBytesWritable value) {
super(new
SQLExceptionInfo.Builder(SQLExceptionCode.DATA_EXCEEDS_MAX_CAPACITY)
.setMessage((columnName == null ? "" : columnName + " ") +
getTypeDisplayString(type, precision, scale, value))
.build().buildException());
}
+
+ public DataExceedsCapacityException(String columnName, String mesage) {
+ super(new SQLExceptionInfo.Builder(
+ SQLExceptionCode.DATA_EXCEEDS_MAX_CAPACITY)
+ .setColumnName(columnName)
+ .setMessage(mesage).build()
+ .buildException());
+ }
+
+ public DataExceedsCapacityException(String columnName, int columnLength) {
+ this(columnName, "maxLength=" + columnLength);
+ }
+
+ @Deprecated
Review comment:
You could also deprecate the method `private static String
getTypeDisplayString(PDataType type, Integer precision, Integer scale,
ImmutableBytesWritable value)` below to avoid accidental usage in future, and
add a new helper method that doesn't take `value` as the argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> DATA_EXCEEDS_MAX_CAPACITY exception error string should contain column name
> instead of actual value
> ----------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6189
> URL: https://issues.apache.org/jira/browse/PHOENIX-6189
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.14.3
> Reporter: Xinyi Yan
> Assignee: Xinyi Yan
> Priority: Trivial
>
> UpsertCompiler raised DATA_EXCEEDS_MAX_CAPACITY exception that contains
> column value instead of the column name.
> https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java#L1263
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
