[
https://issues.apache.org/jira/browse/PHOENIX-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216139#comment-17216139
]
ASF GitHub Bot commented on PHOENIX-6193:
-----------------------------------------
stoty commented on pull request #925:
URL: https://github.com/apache/phoenix/pull/925#issuecomment-711139308
I've re-run the build with warm maven caches:
Pre-6151:
[INFO] Phoenix Client ..................................... SUCCESS [02:20
min]
With this patch:
[INFO] Phoenix Client ..................................... SUCCESS [05:10
min]
So we're still about twice as slow as the original shading setup. Part of
that is probably simply that we are shading more stuff, but using excludes
probably also contributes.
Putting the two client JARs in different modules is certainly possible,
however I did not have much luck running the build in multiple threads. The
test parameters (numITCount) are usually tuned to fully use the test machine,
and -T will cause a lot of test failures due to resource exhaustion. (and if
you are on a very large machine, you're probably still better off increasing
numITCount when running the full test suite)
Since we do not actually test the shaded artifacts, there is not much point
in building them in Jenkins, and they are not useful 95% percent of the time
during local development. We could shave off 10 minutes from the CI builds by
not building the shaded artifacts at all. Yetus sets some default
profile/property that we could re-use for this, and of course this could also
be used locally.
For local development builds that aren't deployed to a real cluster I
usually just use:
mvn clean package -DskipTests -am -pl phoenix-core :
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Phoenix 5.1.0-SNAPSHOT:
[INFO]
[INFO] Phoenix Hbase 2.1.6 compatibility .................. SUCCESS [ 4.551
s]
[INFO] Apache Phoenix ..................................... SUCCESS [ 1.355
s]
[INFO] Phoenix Core ....................................... SUCCESS [ 27.730
s]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 34.456 s
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> PHOENIX-6151 slows down shading
> --------------------------------
>
> Key: PHOENIX-6193
> URL: https://issues.apache.org/jira/browse/PHOENIX-6193
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 5.1.0, 4.16.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Critical
>
> PHOENIX-6151 increases shading time by ~400%, which is a disproportional
> share of the total build time.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
