stoty commented on a change in pull request #933:
URL: https://github.com/apache/phoenix/pull/933#discussion_r509404314
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/util/TestUtil.java
##########
@@ -840,10 +840,16 @@ public static void doMajorCompaction(Connection conn,
String tableName) throws E
byte[] markerRowKey = Bytes.toBytes("TO_DELETE");
Put put = new Put(markerRowKey);
- put.addColumn(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES,
QueryConstants.EMPTY_COLUMN_VALUE_BYTES,
QueryConstants.EMPTY_COLUMN_VALUE_BYTES);
+ long timestamp = 0;
+ // We do not want to wait an hour because of
PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY
+ // So set the timestamp of the put and delete as early as possible
+ put.addColumn(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES,
+ QueryConstants.EMPTY_COLUMN_VALUE_BYTES, timestamp,
+ QueryConstants.EMPTY_COLUMN_VALUE_BYTES);
htable.put(put);
Delete delete = new Delete(markerRowKey);
- delete.addColumn(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES,
QueryConstants.EMPTY_COLUMN_VALUE_BYTES);
+ delete.addColumn(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES,
Review comment:
Maybe use timestamp + 1 here, to make sure that delete comes after the
insert ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
