[
https://issues.apache.org/jira/browse/PHOENIX-6155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230165#comment-17230165
]
Hadoop QA commented on PHOENIX-6155:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
38s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
1s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} 4.x Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
22s{color} | {color:green} 4.x passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
18s{color} | {color:green} 4.x passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 7m
33s{color} | {color:green} 4.x passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
43s{color} | {color:green} 4.x passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 2m
49s{color} | {color:blue} phoenix-core in 4.x has 946 extant spotbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
45s{color} | {color:blue} root in 4.x has 1000 extant spotbugs warnings.
{color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 7m
45s{color} | {color:red} root: The patch generated 527 new + 16154 unchanged -
54 fixed = 16681 total (was 16208) {color} |
| {color:green}+1{color} | {color:green} prototool {color} | {color:green} 0m
2s{color} | {color:green} There were no new prototool issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} spotbugs {color} | {color:red} 3m
3s{color} | {color:red} phoenix-core generated 9 new + 946 unchanged - 0 fixed
= 955 total (was 946) {color} |
| {color:red}-1{color} | {color:red} spotbugs {color} | {color:red} 4m
5s{color} | {color:red} root generated 9 new + 1000 unchanged - 0 fixed = 1009
total (was 1000) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}125m 47s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}174m 58s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:phoenix-core |
| |
org.apache.phoenix.coprocessor.generated.TaskMetaDataProtos$TaskMutateRequest.PARSER
isn't final but should be At TaskMetaDataProtos.java:be At
TaskMetaDataProtos.java:[line 114] |
| | Class
org.apache.phoenix.coprocessor.generated.TaskMetaDataProtos$TaskMutateRequest
defines non-transient non-serializable instance field unknownFields In
TaskMetaDataProtos.java:instance field unknownFields In
TaskMetaDataProtos.java |
| | Useless control flow in
org.apache.phoenix.coprocessor.generated.TaskMetaDataProtos$TaskMutateRequest$Builder.maybeForceBuilderInitialization()
At TaskMetaDataProtos.java: At TaskMetaDataProtos.java:[line 330] |
| | org.apache.phoenix.schema.task.SystemTaskParams.getEndTs() may expose
internal representation by returning SystemTaskParams.endTs At
SystemTaskParams.java:by returning SystemTaskParams.endTs At
SystemTaskParams.java:[line 99] |
| | org.apache.phoenix.schema.task.SystemTaskParams.getStartTs() may expose
internal representation by returning SystemTaskParams.startTs At
SystemTaskParams.java:by returning SystemTaskParams.startTs At
SystemTaskParams.java:[line 95] |
| | new org.apache.phoenix.schema.task.SystemTaskParams(PhoenixConnection,
PTable$TaskType, String, String, String, String, String, Integer, Timestamp,
Timestamp, boolean) may expose internal representation by storing an externally
mutable object into SystemTaskParams.endTs At SystemTaskParams.java:String,
String, String, Integer, Timestamp, Timestamp, boolean) may expose internal
representation by storing an externally mutable object into
SystemTaskParams.endTs At SystemTaskParams.java:[line 58] |
| | new org.apache.phoenix.schema.task.SystemTaskParams(PhoenixConnection,
PTable$TaskType, String, String, String, String, String, Integer, Timestamp,
Timestamp, boolean) may expose internal representation by storing an externally
mutable object into SystemTaskParams.startTs At SystemTaskParams.java:String,
String, String, Integer, Timestamp, Timestamp, boolean) may expose internal
representation by storing an externally mutable object into
SystemTaskParams.startTs At SystemTaskParams.java:[line 57] |
| |
org.apache.phoenix.schema.task.SystemTaskParams$SystemTaskParamsBuilder.setEndTs(Timestamp)
may expose internal representation by storing an externally mutable object
into SystemTaskParams$SystemTaskParamsBuilder.endTs At
SystemTaskParams.java:by storing an externally mutable object into
SystemTaskParams$SystemTaskParamsBuilder.endTs At SystemTaskParams.java:[line
166] |
| |
org.apache.phoenix.schema.task.SystemTaskParams$SystemTaskParamsBuilder.setStartTs(Timestamp)
may expose internal representation by storing an externally mutable object
into SystemTaskParams$SystemTaskParamsBuilder.startTs At
SystemTaskParams.java:by storing an externally mutable object into
SystemTaskParams$SystemTaskParamsBuilder.startTs At
SystemTaskParams.java:[line 161] |
| FindBugs | module:root |
| |
org.apache.phoenix.coprocessor.generated.TaskMetaDataProtos$TaskMutateRequest.PARSER
isn't final but should be At TaskMetaDataProtos.java:be At
TaskMetaDataProtos.java:[line 114] |
| | Class
org.apache.phoenix.coprocessor.generated.TaskMetaDataProtos$TaskMutateRequest
defines non-transient non-serializable instance field unknownFields In
TaskMetaDataProtos.java:instance field unknownFields In
TaskMetaDataProtos.java |
| | Useless control flow in
org.apache.phoenix.coprocessor.generated.TaskMetaDataProtos$TaskMutateRequest$Builder.maybeForceBuilderInitialization()
At TaskMetaDataProtos.java: At TaskMetaDataProtos.java:[line 330] |
| | org.apache.phoenix.schema.task.SystemTaskParams.getEndTs() may expose
internal representation by returning SystemTaskParams.endTs At
SystemTaskParams.java:by returning SystemTaskParams.endTs At
SystemTaskParams.java:[line 99] |
| | org.apache.phoenix.schema.task.SystemTaskParams.getStartTs() may expose
internal representation by returning SystemTaskParams.startTs At
SystemTaskParams.java:by returning SystemTaskParams.startTs At
SystemTaskParams.java:[line 95] |
| | new org.apache.phoenix.schema.task.SystemTaskParams(PhoenixConnection,
PTable$TaskType, String, String, String, String, String, Integer, Timestamp,
Timestamp, boolean) may expose internal representation by storing an externally
mutable object into SystemTaskParams.endTs At SystemTaskParams.java:String,
String, String, Integer, Timestamp, Timestamp, boolean) may expose internal
representation by storing an externally mutable object into
SystemTaskParams.endTs At SystemTaskParams.java:[line 58] |
| | new org.apache.phoenix.schema.task.SystemTaskParams(PhoenixConnection,
PTable$TaskType, String, String, String, String, String, Integer, Timestamp,
Timestamp, boolean) may expose internal representation by storing an externally
mutable object into SystemTaskParams.startTs At SystemTaskParams.java:String,
String, String, Integer, Timestamp, Timestamp, boolean) may expose internal
representation by storing an externally mutable object into
SystemTaskParams.startTs At SystemTaskParams.java:[line 57] |
| |
org.apache.phoenix.schema.task.SystemTaskParams$SystemTaskParamsBuilder.setEndTs(Timestamp)
may expose internal representation by storing an externally mutable object
into SystemTaskParams$SystemTaskParamsBuilder.endTs At
SystemTaskParams.java:by storing an externally mutable object into
SystemTaskParams$SystemTaskParamsBuilder.endTs At SystemTaskParams.java:[line
166] |
| |
org.apache.phoenix.schema.task.SystemTaskParams$SystemTaskParamsBuilder.setStartTs(Timestamp)
may expose internal representation by storing an externally mutable object
into SystemTaskParams$SystemTaskParamsBuilder.startTs At
SystemTaskParams.java:by storing an externally mutable object into
SystemTaskParams$SystemTaskParamsBuilder.startTs At
SystemTaskParams.java:[line 161] |
| Failed junit tests | phoenix.end2end.DerivedTableIT |
| | phoenix.end2end.index.GlobalMutableNonTxIndexIT |
| | phoenix.end2end.index.GlobalMutableTxIndexIT |
| | phoenix.end2end.PointInTimeQueryIT |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/177/artifact/patchprocess/Dockerfile
|
| JIRA Issue | PHOENIX-6155 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13015063/PHOENIX-6155.4.x.000.patch
|
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile cc prototool |
| uname | Linux 3b5ba2ad9e3f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / c9c80b2 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/177/artifact/patchprocess/diff-checkstyle-root.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/177/artifact/patchprocess/new-spotbugs-phoenix-core.html
|
| spotbugs |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/177/artifact/patchprocess/new-spotbugs-root.html
|
| unit |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/177/artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/177/testReport/ |
| Max. process+thread count | 6473 (vs. ulimit of 30000) |
| modules | C: phoenix-core . U: . |
| Console output |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/177/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Prevent doing direct upserts into SYSTEM.TASK from the client
> -------------------------------------------------------------
>
> Key: PHOENIX-6155
> URL: https://issues.apache.org/jira/browse/PHOENIX-6155
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Chinmay Kulkarni
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6155.4.x.000.patch
>
>
> In environments with namespace-mapping enabled, we will have to grant write
> access to clients in order to make direct upserts into SYSTEM.TASK. Currently
> we add a task from the client-side
> [here|https://github.com/apache/phoenix/blob/4.x/phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java#L4654].
> In order to implement other Jiras like
> [PHOENIX-6154|https://issues.apache.org/jira/browse/PHOENIX-6154] we also may
> need to interact with the SYSTEM.TASK table from the client-side.
> Instead of doing direct upserts into this table, we should add an endpoint on
> SYSTEM.TASK and clients should interact with that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
