gjacoby126 commented on a change in pull request #961:
URL: https://github.com/apache/phoenix/pull/961#discussion_r522501965
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
##########
@@ -899,6 +899,39 @@ public void testUpdateNonIndexedColumn() throws Exception {
}
}
+ @Test
+ public void testDeleteCount_nonPK() throws Exception {
+ String schemaName = generateUniqueName();
+ String dataTableName = "TBL_" + generateUniqueName();
Review comment:
I'd lean toward carrying them all over. It seems like we had a testing
gap around affected row counts and you've written a good set of tests to cover
that gap for both kinds of table (even if we have no reason to think there's
anything wrong with mutable tables).
With the right common helper methods it won't add much code and I don't
expect it to lengthen test suite runtime much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
