gjacoby126 commented on a change in pull request #935:
URL: https://github.com/apache/phoenix/pull/935#discussion_r522541892



##########
File path: 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/AddColumnMutator.java
##########
@@ -293,7 +293,9 @@ public MetaDataMutationResult validateAndAddMetadata(PTable 
table, byte[][] rowK
                                                          
List<ImmutableBytesPtr> invalidateList,
                                                          List<Region.RowLock> 
locks,
                                                          long clientTimeStamp,
-                                                         long clientVersion) {
+                                                         long clientVersion,
+                                                         boolean 
isAddingColumns,
+                                                         List<PTable> 
childViews) {

Review comment:
       Good catch, it was necessary in a prior draft but the code that used it 
was just removed. I'll remove the parameter. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to